Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift: Fix icmp_imm for small types in interpreter #4506

Merged
merged 1 commit into from
Jul 23, 2022
Merged

cranelift: Fix icmp_imm for small types in interpreter #4506

merged 1 commit into from
Jul 23, 2022

Conversation

afonso360
Copy link
Contributor

👋 Hey,

This was discovered by fuzzgen after fixing the switch API.

This PR also enables a bunch of icmp tests for s390x that were probably forgotten.

CC: #4502
CC: @jameysharp

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Jul 22, 2022
@afonso360 afonso360 marked this pull request as draft July 22, 2022 11:53
@afonso360 afonso360 force-pushed the interp-icmp-imm-fix branch from d98c724 to a8e8964 Compare July 22, 2022 12:03
@afonso360 afonso360 marked this pull request as ready for review July 22, 2022 12:04
jameysharp
jameysharp approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible, and I like the new tests!

cranelift/interpreter/src/value.rs Outdated Show resolved Hide resolved
@afonso360 afonso360 force-pushed the interp-icmp-imm-fix branch from a8e8964 to 5b17643 Compare July 22, 2022 23:44
@jameysharp jameysharp enabled auto-merge (squash) July 22, 2022 23:50
@jameysharp jameysharp merged commit 446efd3 into bytecodealliance:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameysharp jameysharp jameysharp approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afonso360 @jameysharp